🩹 [Patch]: Update test to connect a GitHub App using Connect-GitHubApp#60
Merged
MariusStorhaug merged 4 commits intomainfrom Jul 1, 2025
Merged
🩹 [Patch]: Update test to connect a GitHub App using Connect-GitHubApp#60MariusStorhaug merged 4 commits intomainfrom
Connect-GitHubApp#60MariusStorhaug merged 4 commits intomainfrom
Conversation
…ns and display contexts and Git configuration
…mproved context retrieval
…l to use Format-List for improved readability
…or consistency in workflow
MariusStorhaug
changed the title
Connect-GitHubAppConnect-GitHubApp
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test workflow to use the new Connect-GitHubApp wrapper, standardizes several output formats, and replaces manual installation token handling with a single command.
- Switched
Get-GitHubAppandGet-GitHubConfigoutputs from table to list formatting - Removed manual token generation and
Connect-GitHubcalls in favor ofConnect-GitHubApp - Added dedicated log groups for available contexts and GitHub configuration
Comments suppressed due to low confidence (3)
.github/workflows/TestWorkflow.yml:498
- The
Connect-GitHubAppcall isn’t piped throughFormat-ListorOut-String, so its output won’t be captured in the log group. Consider piping it toFormat-List | Out-Stringfor consistency with other blocks.
LogGroup 'Connect to all installations of the app' {
.github/workflows/TestWorkflow.yml:503
- [nitpick] Consider using
Format-Listhere instead ofFormat-Tableto match the list formatting used elsewhere and avoid table-wrapping issues in CI logs.
Get-GitHubContext -ListAvailable | Format-Table -AutoSize | Out-String
.github/workflows/TestWorkflow.yml:533
- [nitpick] This block is duplicated across multiple jobs. Extracting it into a reusable workflow snippet or composite action would reduce duplication and improve maintainability.
LogGroup 'Connect to all installations of the app' {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
.github/workflows/TestWorkflow.ymlfile to improve the organization and output formatting of GitHub-related logs in the workflow scripts. The most important changes include switching fromFormat-TabletoFormat-Listfor better readability, restructuring log groups for clarity, and replacing specific installation token-based connections with a streamlinedConnect-GitHubAppcommand.Improvements to output formatting:
Format-TabletoFormat-ListforGet-GitHubAppandGet-GitHubConfigcommands to enhance readability. [1] [2]Workflow restructuring:
New-GitHubAppInstallationAccessTokenandConnect-GitHub) with a simplifiedConnect-GitHubAppcommand to connect to all installations of the app. [1] [2]Contexts(Get-GitHubContext -ListAvailable) andGitHubConfig(Get-GitHubConfig) to improve clarity and organization of workflow logs. [1] [2]Type of change
Checklist